-
Notifications
You must be signed in to change notification settings - Fork 50
Add Application Credential support #829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Deydra71 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Note: kuttl tests are yet to be added |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/9f80e1823add462ea5c60df2672f72d6 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 21m 14s |
Signed-off-by: Veronika Fisarova <[email protected]>
ce6f6b9 to
e70d887
Compare
|
@Deydra71: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/c51230a124434844b7ac185afdb52021 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 53m 25s |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
|
||
| replace k8s.io/kube-openapi => k8s.io/kube-openapi v0.0.0-20250627150254-e9823e99808e //allow-merging | ||
|
|
||
| replace github.com/openstack-k8s-operators/keystone-operator/api => github.com/Deydra71/keystone-operator/api v0.0.0-20251211085602-3e1a3e022c81 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this kind of replacement from an official to a non-official package name is intentional here?
|
|
||
| replace k8s.io/kube-openapi => k8s.io/kube-openapi v0.0.0-20250627150254-e9823e99808e //allow-merging | ||
|
|
||
| replace github.com/openstack-k8s-operators/keystone-operator/api => github.com/Deydra71/keystone-operator/api v0.0.0-20251211085602-3e1a3e022c81 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here, this weird package name looks fishy.
| @@ -1,3 +1,5 @@ | |||
| github.com/Deydra71/keystone-operator/api v0.0.0-20251211085602-3e1a3e022c81 h1:plax+NFgJJL1SrERyXAnf3jOHRhLTtBlJ2oc7d84EoU= | |||
| github.com/Deydra71/keystone-operator/api v0.0.0-20251211085602-3e1a3e022c81/go.mod h1:b98Jl8eyUw8V07l9YiuQnoMlnWC748oV8IhXH15NCC4= | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not pull from non openstack-k8s-operators
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mrunge ! It's only temporary before the dependency in keystone-oeprator is merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After that, it will be removed before final reviews and merge
Jira: OSPRH-16628
Adds end-to-end support for consuming Keystone Application Credentials (AppCred) in the telemetry-operator, enabling Ceilometer, Aodh, and CloudKitty pods to use AppCred-based authentication when available.
API changes:
Adds an optional auth field to telemetry service CRs:
spec.auth.applicationCredentialSecret— name of the Secret that contains the Keystone Application Credential ID and Secret (AC_IDandAC_SECRET).This is added for:
Reconcile behavior:
spec.auth.applicationCredentialSecretAC_ID/AC_SECRETfrom the referenced Secret (via the Keystone helper)Once the AppCred Secret is ready with valid
AC_ID/AC_SECRET:Templates AppCred credentials into the generated service configuration (e.g.
ceilometer.conf,aodh.conf,cloudkitty.conf)The rendered config hash naturally includes AppCred values, triggering rolling updates when credentials rotate
All controllers use the same service user’s AppCred Secret for their respective service (ceilometer/aodh/cloudkitty)
Updates Keystone auth sections to support AppCred with a block-based if/else structure:
auth_type = v3applicationcredential+application_credential_id+application_credential_secretDepends-on: openstack-k8s-operators/keystone-operator#567